-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ATS entirely #6642
Disable ATS entirely #6642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Supporting Files/Info.plist
line 65 at r1 (raw file):
</dict> </dict> <key>NSPinnedDomains</key>
we haven't set SSLPinningURLSessionDelegate
for the url session of OutgoingConnectionProxy
.if we are gonna removing pining here then we have to add SSLPinningURLSessionDelegate
into OutgoingConnectionProxy
.
Code snippet:
outgoingConnectionProxy: OutgoingConnectionProxy(
urlSession: REST.makeURLSession(),
hostname: ApplicationConfiguration.hostName
)
775dc5b
to
6a5bdb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/Supporting Files/Info.plist
line 65 at r1 (raw file):
Previously, mojganii wrote…
we haven't set
SSLPinningURLSessionDelegate
for the url session ofOutgoingConnectionProxy
.if we are gonna removing pining here then we have to addSSLPinningURLSessionDelegate
intoOutgoingConnectionProxy
.
Good catch ! I've fixed SSLPinningURLSessionDelegate
to work with conn-check too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
9a5f72e
to
29775fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
29775fb
to
8ff7f7c
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This PR disables ATS entirely from our application.
This requires justifying to apple why we do this, and we feel we have a good explanation in hand :
This change is